feat: Adding debug mode to local node. #465
Conversation
stefan-stefanooov
added
Feature Enhancement
stefan-stefanooov
requested review from
Ivo-Yankov,
georgi-l95,
isavov,
natanasow and
konstantinabl
stefan-stefanooov
force-pushed
the
269-fix-debug-mode-and-add-documentation
branch
from
16a9079 to
2ccfdf1
Compare
stefan-stefanooov
force-pushed
the
269-fix-debug-mode-and-add-documentation
branch
from
67a7ffa to
e314d8b
Compare
| local: | ||
| deleteAfterProcessing: true |
There was a problem hiding this comment.
Remove this, so we get the default from the mirror-node itself. If we need to enable it, will do so when starting the local-node itself and clean it after starting.
There was a problem hiding this comment.
This flag needs to be present in the context of the whole debug workflow.
This is the only way, I think, to double check that the Mirror node is started with "deleting of the record files disabled"
If you want to clear this. We need to start a cleanup procedure on localnode stop
Unfortunately we already execute cleanup state on the start command
SO this means we need to pass the previous step as a parameter of the current. Or something like that...
I think setting this flag on every command is the simplest.
stefan-stefanooov
force-pushed
the
269-fix-debug-mode-and-add-documentation
branch
3 times, most recently
from
ef7083a to
d3c6c0a
Compare
src/state/InitState.ts
Outdated
| application.hedera.mirror.importer.downloader['local']['deleteAfterProcessing'] = !debugMode | ||
|
|
There was a problem hiding this comment.
Add this to originalNodeProperties.json with key debugNodeProperties and then use it similar to the others.
There was a problem hiding this comment.
OK... I did as you asked in the current state of the MR. But I don't get how this solves our problem.
CLIs are not suppose to and can't hold state between command executions.
Because of this, there is no way of knowing (inside the debug command) how was the Local Node started.
And we have a requirement to start it, with the flag we are discussing, set to
false.
That's why I created this function checkForDebugMode that checks exactly that. And outputs an error if you try to debug with local node not in debug mode.
We set the flag on InitState but we clean it in CleanUpState
The only way of passing state to it is config file. As far as I can see.
There was a problem hiding this comment.
Maybe a good solution would be to combine the two commands:
- when we start in debug mode. we would start asking the user for timestamp
- output whatever is in the record file
- prompt again / or exit
That way we would always be in the context of the start (with debug) command. And we will STOP the execution on exit.
Maybe we could use inquirer or any other lib to achieve that ?
stefan-stefanooov
force-pushed
the
269-fix-debug-mode-and-add-documentation
branch
from
d3c6c0a to
aa7df82
Compare
Signed-off-by: Stefan Stefanov <stefan.stefanooov@gmail.com>
Signed-off-by: Stefan Stefanov <stefan.stefanooov@gmail.com>
Signed-off-by: Stefan Stefanov <stefan.stefanooov@gmail.com>
Signed-off-by: Stefan Stefanov <stefan.stefanooov@gmail.com>
stefan-stefanooov
force-pushed
the
269-fix-debug-mode-and-add-documentation
branch
from
7ea281e to
5b1b4c6
Compare
|
Description:
run hedera debug with any valid timestmp returns the record file for that timestamp
Related issue(s):
Fix debug mode and add documentation#269