docs: gitpod review #563
Merged
docs: gitpod review #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
=======================================
Coverage 51.02% 51.02%
=======================================
Files 24 24
Lines 1172 1172
Branches 131 131
=======================================
Hits 598 598
Misses 550 550
Partials 24 24 ☔ View full report in Codecov by Sentry. |
bguiz
force-pushed
the
docs/gitpod-review
branch
from
b027629 to
d47d3ee
Compare
bguiz
force-pushed
the
docs/gitpod-review
branch
from
d47d3ee to
92d3a00
Compare
|
Hello,
|
- based on review from @Yaroslav-00 hiero-ledger#563 (comment)
|
Thanks for the review! I've addressed your comments in |
|
andrewb1269hg
added a commit
that referenced
this pull request
Oct 29, 2024
commit 336082b Remove db override commit 3af747a chore: Bump actions/setup-node from 4.0.2 to 4.1.0 (#813) commit 51a228f Update readme about keys usage (#8) commit 61470e8 ci: Updated nick-fields/retry v3.2.0 with step-security/retry v3.0.0 (#655) commit 8379b9f fix: resolve windows issue (#138) commit 9840fd1 add gitignore file commit 9cd1a7b Add submodules for mirrornode and point them to services 0.11.0 and mirror 0.27.0 commit a67b7de docs: gitpod review (#563) commit ae9e705 add .env file for services repositories and versions commit b927f09 fix spacing in docker compose file commit ba4b9d4 Add apache license commit cb12fa8 add readme commit cf71d97 Add docker-compose override files, configs, and initial address books commit d343276 Add env variables for various memory limits (#13) commit d4cf91c bump version (#237) commit ff6a728 chore: update PR check workflow (#568) Signed-off-by: Andrew Brandt <andrew.brandt@hashgraph.com>
rbarkerSL
added a commit
that referenced
this pull request
Jan 15, 2025
commit 2466b28 chore: Bump codecov/codecov-action from 5.0.4 to 5.0.7 (#860) commit 336082b Remove db override commit 3af747a chore: Bump actions/setup-node from 4.0.2 to 4.1.0 (#813) commit 41f6b53 chore: Bump step-security/harden-runner from 2.10.1 to 2.10.2 (#852) commit 51a228f Update readme about keys usage (#8) commit 60ca5dd chore: Bump codecov/codecov-action from 4.6.0 to 5.0.0 (#843) commit 61470e8 ci: Updated nick-fields/retry v3.2.0 with step-security/retry v3.0.0 (#655) commit 8379b9f fix: resolve windows issue (#138) commit 97c6b24 chore: Bump codecov/codecov-action from 5.0.2 to 5.0.4 (#858) commit 9840fd1 add gitignore file commit 9cd1a7b Add submodules for mirrornode and point them to services 0.11.0 and mirror 0.27.0 commit a67b7de docs: gitpod review (#563) commit ae9e705 add .env file for services repositories and versions commit b927f09 fix spacing in docker compose file commit ba4b9d4 Add apache license commit c06ba33 fix: small fix commit cb12fa8 add readme commit cf71d97 Add docker-compose override files, configs, and initial address books commit d343276 Add env variables for various memory limits (#13) commit d4cf91c bump version (#237) commit ff6a728 chore: update PR check workflow (#568) Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
What
Why
Related issue(s):
Fixes: nil
Notes for reviewer:
Refs:
Checklist