Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GRPC keepalive options #424

Merged

Conversation

rwalworth
Copy link
Contributor

Description:
This PR adds the additional gRPC configuration options to assist in correct connection behavior. They match the configuration options added in hiero-ledger/hiero-sdk-js#1656.

Related issue(s):

Fixes #422

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Rob Walworth <robert.walworth@swirldslabs.com>
@rwalworth rwalworth added Bug A error that causes the feature to behave differently than what was expected based on design docs Improvement Code changes driven by non business requirements labels Jul 14, 2023
@rwalworth rwalworth self-assigned this Jul 14, 2023
@rwalworth rwalworth linked an issue Jul 14, 2023 that may be closed by this pull request
@rwalworth rwalworth changed the title Add GRCP keepalive options Add GRPC keepalive options Jul 14, 2023
Copy link
Contributor

@deyanzz deyanzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rwalworth rwalworth merged commit 3386987 into main Jul 19, 2023
@rwalworth rwalworth deleted the 00422-check-to-see-if-grpc-configurations-need-to-be-updated branch July 19, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs Improvement Code changes driven by non business requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check to see if GRPC configurations need to be updated
2 participants