-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(HIP-991): Permissionless revenue - Generating Topic Ids for Topic Operators #895
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
…d Integration tests Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
* @return A reference to this derived Transaction object with cleared custom fee limits. | ||
* @throws IllegalStateException If this Transaction is frozen. | ||
*/ | ||
SdkRequestType& clearCustomFeeLimits(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe for now, since TopicMessageSubmitTransaction
is the only transaction that uses this value, we were going to implement these functions there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The custom_fee_limits
defined in the protobufs belongs to transaction.proto
https://github.com/hashgraph/hedera-protobufs/blob/c0ca3524f2e80e5d5e545e36fcb5d23d64c31fb5/services/transaction.proto and has no corresponding entry in consensus_submit_message.proto
. I'm guessing this is decided for further extendability as some other transaction might benefit from the functionality. If I work around the implementation to be explicitly present in TopicSubmitMessage
maybe this would have to be reworked at some future point.
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Description:
This HIP introduces new transactions and updates to existing transactions in the consensus node software. SDKs will need to support these new transactions and updates to existing ones so that developers can take advantage of the new features.
Also introduced
setTestClientOperator
,setDefaultTestClientOperator
functions toBaseIntegration
.Related issue(s):
Fixes #750
Notes for reviewer:
transaction.pb.h
astransaction_body.pb.h
was deleted.AccountStakersQuery
has been dropped from consensus support.Checklist