Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HIP-991): Permissionless revenue - Generating Topic Ids for Topic Operators #895

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gsstoykov
Copy link
Contributor

@gsstoykov gsstoykov commented Feb 13, 2025

Description:

This HIP introduces new transactions and updates to existing transactions in the consensus node software. SDKs will need to support these new transactions and updates to existing ones so that developers can take advantage of the new features.

  • Implementation
  • Unit tests
  • E2E tests
  • Example

Also introduced setTestClientOperator, setDefaultTestClientOperator functions to BaseIntegration.

Related issue(s):

Fixes #750

Notes for reviewer:

  • Unit tests had to be reworked to include transaction.pb.h as transaction_body.pb.h was deleted.
  • AccountStakersQuery has been dropped from consensus support.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov gsstoykov self-assigned this Feb 13, 2025
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
…d Integration tests

Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov gsstoykov marked this pull request as ready for review February 19, 2025 22:16
@gsstoykov gsstoykov requested review from a team as code owners February 19, 2025 22:16
* @return A reference to this derived Transaction object with cleared custom fee limits.
* @throws IllegalStateException If this Transaction is frozen.
*/
SdkRequestType& clearCustomFeeLimits();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe for now, since TopicMessageSubmitTransaction is the only transaction that uses this value, we were going to implement these functions there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom_fee_limits defined in the protobufs belongs to transaction.proto https://github.com/hashgraph/hedera-protobufs/blob/c0ca3524f2e80e5d5e545e36fcb5d23d64c31fb5/services/transaction.proto and has no corresponding entry in consensus_submit_message.proto. I'm guessing this is decided for further extendability as some other transaction might benefit from the functionality. If I work around the implementation to be explicitly present in TopicSubmitMessage maybe this would have to be reworked at some future point.

Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HIP-991 Permissionless revenue-generating Topic Ids for Topic Operators
2 participants