fix: replace manual receipt query execution with GetReceipt
#1092
+28
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When manual
ReceiptQuery
is executed, the status returned is not validated, meaning it will not return error object.Error object is returned only when the receipt query is executed by
GetReceipt
on the transaction result.Currently if a transaction fails with throttle status and we call
GetReceipt
, it will retry, but if we create the receipt separately it would not retry or return an error.This causes some integration tests to have flaky behaviour. Additionally manual execution of
ReceiptQuery
will return no error when an error code is actually returned.This PR:
GetReceipt
in e2e tests.GetReceipt
in flows.Related issue(s):
Fixes #1079
Notes for reviewer:
Checklist