Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace /math package #1121

Merged
merged 3 commits into from
Oct 28, 2024
Merged

chore: Replace /math package #1121

merged 3 commits into from
Oct 28, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Oct 28, 2024

Description:
Replace /math package

Related issue(s):

Fixes #1111

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov self-assigned this Oct 28, 2024
@0xivanov 0xivanov requested review from a team as code owners October 28, 2024 07:50
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 39.47368% with 46 lines in your changes missing coverage. Please review.

Project coverage is 72.20%. Comparing base (2104601) to head (c6e5714).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
contract_function_parameters.go 4.16% 46 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1121      +/-   ##
==========================================
+ Coverage   72.13%   72.20%   +0.06%     
==========================================
  Files         174      175       +1     
  Lines       28743    28770      +27     
==========================================
+ Hits        20735    20774      +39     
+ Misses       7263     7251      -12     
  Partials      745      745              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Copy link

@0xivanov 0xivanov merged commit c23ea4f into main Oct 28, 2024
12 of 13 checks passed
@0xivanov 0xivanov deleted the replace-math-package branch October 28, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace /common/abi from go-ethereum
2 participants