Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update per Q3 audit findings #1123

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

mishomihov00
Copy link
Contributor

Description:

Update per Q3 audit findings

Related issue(s):

Related to #1007

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mishomihov00 mishomihov00 requested review from a team as code owners October 30, 2024 12:45
@mishomihov00 mishomihov00 linked an issue Oct 30, 2024 that may be closed by this pull request
53 tasks
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.20%. Comparing base (b2b7688) to head (f1b73d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
- Coverage   74.25%   74.20%   -0.05%     
==========================================
  Files         174      174              
  Lines       21624    21624              
==========================================
- Hits        16057    16047      -10     
- Misses       4899     4909      +10     
  Partials      668      668              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

0xivanov
0xivanov previously approved these changes Nov 1, 2024
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

agadzhalov
agadzhalov previously approved these changes Nov 5, 2024
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mishomihov00 mishomihov00 force-pushed the 1007-ci-2024-q3-cicd-audit-story branch from ab34610 to c9b6d49 Compare November 5, 2024 08:39
jeromy-cannon
jeromy-cannon previously approved these changes Nov 5, 2024
@mishomihov00 mishomihov00 force-pushed the 1007-ci-2024-q3-cicd-audit-story branch 2 times, most recently from d346825 to e41c9a8 Compare November 6, 2024 08:42
Signed-off-by: Mihail Mihov <mihail.mihov@limechain.tech>
Signed-off-by: Mihail Mihov <mihail.mihov@limechain.tech>
@mishomihov00 mishomihov00 force-pushed the 1007-ci-2024-q3-cicd-audit-story branch from e41c9a8 to f1b73d6 Compare November 6, 2024 08:44
Copy link

sonarqubecloud bot commented Nov 6, 2024

@mishomihov00 mishomihov00 merged commit c70eb24 into main Nov 7, 2024
12 of 13 checks passed
@mishomihov00 mishomihov00 deleted the 1007-ci-2024-q3-cicd-audit-story branch November 7, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: [2024-Q3] CI/CD Audit Story
4 participants