Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create client without schedule network update #1141

Merged

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Nov 18, 2024

Description:

Adding a new api that if a JSON config is provided there is no need for the address book update thread.

Related issue(s):

Fixes #1130

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov self-assigned this Nov 18, 2024
@0xivanov 0xivanov requested review from a team as code owners November 18, 2024 09:51
Copy link

Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@0xivanov 0xivanov merged commit 646ce67 into main Nov 18, 2024
11 checks passed
@0xivanov 0xivanov deleted the 1130-ClientFromConfig-without-background-addressbook-update branch November 18, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants