Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Hiero renaming initial #1152

Merged
merged 10 commits into from
Nov 27, 2024
Merged

chore: Hiero renaming initial #1152

merged 10 commits into from
Nov 27, 2024

Conversation

gsstoykov
Copy link
Contributor

@gsstoykov gsstoykov commented Nov 20, 2024 •
edited
Loading

Description:
This PR introduces Hiero renaming for the GO SDK.

Related issue(s):

Fixes #1081

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@gsstoykov
feat: Hiero renaming initial
d4e5310 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov gsstoykov self-assigned this Nov 20, 2024
@gsstoykov gsstoykov linked an issue Nov 20, 2024 that may be closed by this pull request
Rename any usage of “Hedera”, “Swirlds” or “Hashgraph” to “Hiero” #1081
Closed
@gsstoykov
fix: Revert CODEOWNERS update
e232ba0 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
fix: Restore CODEOWNERS
c22b557 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
rbarkerSL
rbarkerSL requested changes Nov 20, 2024
View reviewed changes
.github/CODEOWNERS Show resolved Hide resolved
@gsstoykov
fix: CODEOWNERS sugested fix
01a5efc 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
rbarkerSL
rbarkerSL requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend addressing merge conflicts on main.yml and updating to the latest. I believe

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@cweagans cweagans mentioned this pull request Nov 21, 2024
Closed
gsstoykov and others added 5 commits November 26, 2024 10:25
@gsstoykov @rbarkerSL
Update .github/CODEOWNERS
a5070dd 
Co-authored-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
merge: Merged main branch into renaming
a8bac51 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
fix: go mod tidy
d721f9e 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
fix: Added more renamings
3d95873 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@gsstoykov
fix: TestIntegrationTransactionRecordQueryCanExecute
9c8759f 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
client.go 50.00% 1 Missing ⚠️
errors.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
abi.go 59.70% <ø> (ø)
abi_decode.go 54.09% <ø> (ø)
abi_encode.go 47.58% <ø> (ø)
abi_type.go 78.19% <ø> (ø)
account_allowance_approve_transaction.go 72.46% <ø> (ø)
account_allowance_delete_transaction.go 90.35% <ø> (ø)
account_balance.go 100.00% <ø> (ø)
account_balance_query.go 85.84% <ø> (ø)
account_create_transaction.go 97.25% <ø> (ø)
account_delete_transaction.go 97.59% <ø> (ø)
... and 114 more

... and 56 files with indirect coverage changes

@gsstoykov gsstoykov marked this pull request as ready for review November 26, 2024 12:47
@gsstoykov gsstoykov requested a review from 0xivanov November 26, 2024 12:48
@gsstoykov
fix: main.yml format
241872b 
Signed-off-by: gsstoykov <georgi.stoykov@limechain.tech>
0xivanov
0xivanov approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed Go files.

@gsstoykov gsstoykov requested a review from rbarkerSL November 26, 2024 14:35
rbarkerSL
rbarkerSL approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval applies to the following files:

  • .github/CODEOWNERS
  • .github/workflows/main.yml
  • CHANGELOG.md
  • LICENSE
  • README.md
  • go.mod
  • tck/go.mod

I would like to here from @hendrikebbers or @nathanklick on if the change to the license file should have removed the hashgraph copyright or not? but this LGTM

@gsstoykov
Copy link
Contributor Author

@rbarkerSL In C++ SDK we got it in with removing the Hashgraph copyright. We had some discussions around that topic. Will merge the PR if something comes up I will open a followup to change it.

@gsstoykov gsstoykov merged commit 236e8b3 into main Nov 27, 2024
5 of 6 checks passed
@gsstoykov gsstoykov deleted the 1081-rename-any-usage-of-hedera-swirlds-or-hashgraph-to-hiero branch November 27, 2024 08:14
This was referenced Nov 27, 2024
Closed
Closed
@laggu laggu mentioned this pull request Dec 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbarkerSL rbarkerSL rbarkerSL approved these changes

@0xivanov 0xivanov 0xivanov approved these changes

Assignees

@gsstoykov gsstoykov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename any usage of “Hedera”, “Swirlds” or “Hashgraph” to “Hiero”
3 participants
@gsstoykov @0xivanov @rbarkerSL