Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (HIP-423): Long Term Scheduled Transactions #1181

Merged
merged 10 commits into from
Dec 11, 2024
Merged

feat (HIP-423): Long Term Scheduled Transactions #1181

merged 10 commits into from
Dec 11, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Dec 9, 2024

Implements HIP-423:

  1. Integration tests
  2. Example

Fixes: #1165

@0xivanov
chore: update protobufs to v0.57
3509638 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: enable integration tests
9ef1444 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: add integration tests for hip 423
a2be701 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: add example
3683727 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov added the enhancement New feature or request label Dec 9, 2024
@0xivanov 0xivanov self-assigned this Dec 9, 2024
@0xivanov 0xivanov requested review from a team as code owners December 9, 2024 13:32
Base automatically changed from update-protobufs-to-v0.57 to main December 9, 2024 14:19
@0xivanov 0xivanov requested review from a team as code owners December 9, 2024 14:26
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

see 2 files with indirect coverage changes

@0xivanov
chore: refactor
d667e0b 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
mishomihov00
mishomihov00 previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to .github/workflows/build.yml

@0xivanov
chore: fix tx fee issue
a8ef51c 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: enable test
166322b 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
gsstoykov
gsstoykov reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Just some nits.

schedule_create_transaction_e2e_test.go Outdated Show resolved Hide resolved
schedule_create_transaction_e2e_test.go Show resolved Hide resolved
@0xivanov
chore: address feedback
dc00c2d 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
gsstoykov
gsstoykov approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@0xivanov 0xivanov merged commit 0033954 into main Dec 11, 2024
6 checks passed
@0xivanov 0xivanov deleted the 1165-hip-423-Long-Term-Scheduled-Transactions branch December 11, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsstoykov gsstoykov gsstoykov approved these changes

@mishomihov00 mishomihov00 mishomihov00 left review comments

Assignees

@0xivanov 0xivanov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add HIP-423: Long Term Scheduled Transactions
3 participants
@0xivanov @gsstoykov @mishomihov00