feat: TokenRejectFlow refactor
#1235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Codecov ReportAttention: Patch coverage is
|
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
gsstoykov
reviewed
Jan 29, 2025
Comment on lines
+8
to
+11
| ownerID *AccountID | ||
| tokenIDs []TokenID | ||
| nftIDs []NftID | ||
| freezeWithClient *Client |
There was a problem hiding this comment.
My initial idea was using ownerIds, tokenIds only on the transactions themselves. The freeze would also be done on the separate transactions. So the client won't be passed to the TokenRejectFlow. The only thing we need to use in the Flow would be a PrivateKey if sign is needed on that level.
There was a problem hiding this comment.
Yeah I faced some problems with keeping the API the same in JS using that method. I will check if it can work in Go.
| } | ||
| tokenDissociateTxn := NewTokenDissociateTransaction() | ||
|
|
||
| func (tx *TokenRejectFlow) fillTokenDissociate() error { |
There was a problem hiding this comment.
The same will be valid for the fillTransactions. As they could also be removed I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
TokenRejectFlowclass and similar transaction flows are overly reliant on class hierarchies that treat flows as if they are transactions themselves. This design complicates the implementation and maintenance of transaction flows.This PR does not change the API, but only adds getters to allow modification to the individual transactions.