Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Contribution Guide #1322

Closed
ochikov opened this issue Nov 15, 2022 · 0 comments · Fixed by #1353
Closed

Update Contribution Guide #1322

ochikov opened this issue Nov 15, 2022 · 0 comments · Fixed by #1353
Assignees
@ochikov
Labels
enhancement New feature or request
Milestone
2.19.1

Comments

@ochikov
Copy link
Contributor

ochikov commented Nov 15, 2022

Problem

The contribution guide is outdated and needs to be updated. The building of SDK is based on different kind of approach.

Solution

  • Prerequisites for building the app
  • Describing the right process for building the SDK
  • How to open PR and who to include in it
  • Testing requirements

Alternatives

No response
@ochikov ochikov added the enhancement New feature or request label Nov 15, 2022
@Petyo-Lukanov Petyo-Lukanov added this to the 2.19.1 milestone Nov 28, 2022
@ochikov ochikov self-assigned this Dec 9, 2022
@ochikov ochikov mentioned this issue Dec 9, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ochikov ochikov

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.19.1
Development

Successfully merging a pull request may close this issue.

Update contribution guide hiero-ledger/hiero-sdk-js
2 participants
@ochikov @Petyo-Lukanov