Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution guide #1353

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Update contribution guide #1353

merged 1 commit into from
Dec 9, 2022

Conversation

ochikov
Copy link
Contributor

@ochikov ochikov commented Dec 9, 2022

Description:
Contribution guide updated.

Related issue(s):

Fixes #1322

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 83.54% // Head: 83.47% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (e19f779) compared to base (dfc5c87).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1353      +/-   ##
===========================================
- Coverage    83.54%   83.47%   -0.07%     
===========================================
  Files          292      292              
  Lines        72854    72854              
===========================================
- Hits         60864    60816      -48     
- Misses       11990    12038      +48     
Impacted Files Coverage Δ
src/PrivateKey.js 92.09% <100.00%> (ø)
src/network/AddressBookQuery.js 73.26% <0.00%> (-17.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@petreze petreze merged commit e6deef4 into develop Dec 9, 2022
@petreze petreze deleted the fix/contribution-guide branch December 9, 2022 15:52
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Contribution Guide
2 participants