Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contractId as possible input for AccountAllowancesApproveTransaction #1575

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

ochikov
Copy link
Contributor

@ochikov ochikov commented Apr 25, 2023

Description:
Add contractId as possible input for AccountAllowancesApproveTransaction

Related issue(s):

Fixes #1557

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: ochikov <ognyan@limechain.tech>
@petreze petreze merged commit 1b5f954 into develop Apr 25, 2023
@petreze petreze deleted the fix/account-allowances-contractId branch April 25, 2023 11:48
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
…ion (hiero-ledger#1575)

* Add contractId as possible input for AccountAllowancesApproveTransaction

Signed-off-by: ochikov <ognyan@limechain.tech>

* remove unused code

Signed-off-by: ochikov <ognyan@limechain.tech>

---------

Signed-off-by: ochikov <ognyan@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContractId not usable for allowance approval via AccountAllowanceApproveTransaction
2 participants