Fix/issue with encode decode #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ochikov <ognyan@limechain.tech>
Signed-off-by: ochikov <ognyan@limechain.tech>
Signed-off-by: ochikov <ognyan@limechain.tech>
Signed-off-by: ochikov <ognyan@limechain.tech>
…ion test Signed-off-by: ochikov <ognyan@limechain.tech>
|
Kudos, SonarCloud Quality Gate passed!
|
petreze
approved these changes
Jun 19, 2023
ochikov
added a commit
that referenced
this pull request
Jun 20, 2023
* refactor and add integration tests Signed-off-by: ochikov <ognyan@limechain.tech> * fix linter Signed-off-by: ochikov <ognyan@limechain.tech> * add ds store ignore Signed-off-by: ochikov <ognyan@limechain.tech> * remove the max attempts from commonJs tests Signed-off-by: ochikov <ognyan@limechain.tech> * change the mainnet topicId subscription in TopicMessageQuery integration test Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech>
petreze
added a commit
that referenced
this pull request
Jun 23, 2023
* testing configurations and plugins for babel Signed-off-by: ochikov <ognyan@limechain.tech> * bump up version Signed-off-by: ochikov <ognyan@limechain.tech> * babel options and exports Signed-off-by: ochikov <ognyan@limechain.tech> * options for babel and for properly building the SDK Signed-off-by: ochikov <ognyan@limechain.tech> * Fix/issue with encode decode (#1647) * refactor and add integration tests Signed-off-by: ochikov <ognyan@limechain.tech> * fix linter Signed-off-by: ochikov <ognyan@limechain.tech> * add ds store ignore Signed-off-by: ochikov <ognyan@limechain.tech> * remove the max attempts from commonJs tests Signed-off-by: ochikov <ognyan@limechain.tech> * change the mainnet topicId subscription in TopicMessageQuery integration test Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * fix exact version of grpc librart (#1652) Signed-off-by: ochikov <ognyan@limechain.tech> * remove ping all from the integration test env setup (#1650) Signed-off-by: ochikov <ognyan@limechain.tech> * changelog and version updated Signed-off-by: ochikov <ognyan@limechain.tech> * fix getting a random node when the list is not locked (#1654) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare for release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare stable release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Co-authored-by: ochikov <ognyan@limechain.tech> Co-authored-by: Ognyan Chikov <ochikov@users.noreply.github.com>
petreze
added a commit
that referenced
this pull request
Jun 28, 2023
* Release/v2.28.0 (#1655) * testing configurations and plugins for babel Signed-off-by: ochikov <ognyan@limechain.tech> * bump up version Signed-off-by: ochikov <ognyan@limechain.tech> * babel options and exports Signed-off-by: ochikov <ognyan@limechain.tech> * options for babel and for properly building the SDK Signed-off-by: ochikov <ognyan@limechain.tech> * Fix/issue with encode decode (#1647) * refactor and add integration tests Signed-off-by: ochikov <ognyan@limechain.tech> * fix linter Signed-off-by: ochikov <ognyan@limechain.tech> * add ds store ignore Signed-off-by: ochikov <ognyan@limechain.tech> * remove the max attempts from commonJs tests Signed-off-by: ochikov <ognyan@limechain.tech> * change the mainnet topicId subscription in TopicMessageQuery integration test Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * fix exact version of grpc librart (#1652) Signed-off-by: ochikov <ognyan@limechain.tech> * remove ping all from the integration test env setup (#1650) Signed-off-by: ochikov <ognyan@limechain.tech> * changelog and version updated Signed-off-by: ochikov <ognyan@limechain.tech> * fix getting a random node when the list is not locked (#1654) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare for release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare stable release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Co-authored-by: ochikov <ognyan@limechain.tech> Co-authored-by: Ognyan Chikov <ochikov@users.noreply.github.com> * initial approach Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * improve grpc calls Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Co-authored-by: ochikov <ognyan@limechain.tech> Co-authored-by: Ognyan Chikov <ochikov@users.noreply.github.com>
petreze
added a commit
that referenced
this pull request
Jun 30, 2023
* testing configurations and plugins for babel Signed-off-by: ochikov <ognyan@limechain.tech> * bump up version Signed-off-by: ochikov <ognyan@limechain.tech> * babel options and exports Signed-off-by: ochikov <ognyan@limechain.tech> * options for babel and for properly building the SDK Signed-off-by: ochikov <ognyan@limechain.tech> * Fix/issue with encode decode (#1647) * refactor and add integration tests Signed-off-by: ochikov <ognyan@limechain.tech> * fix linter Signed-off-by: ochikov <ognyan@limechain.tech> * add ds store ignore Signed-off-by: ochikov <ognyan@limechain.tech> * remove the max attempts from commonJs tests Signed-off-by: ochikov <ognyan@limechain.tech> * change the mainnet topicId subscription in TopicMessageQuery integration test Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * fix exact version of grpc librart (#1652) Signed-off-by: ochikov <ognyan@limechain.tech> * remove ping all from the integration test env setup (#1650) Signed-off-by: ochikov <ognyan@limechain.tech> * changelog and version updated Signed-off-by: ochikov <ognyan@limechain.tech> * fix getting a random node when the list is not locked (#1654) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare for release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare stable release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * GRPC improvements (#1656) * Release/v2.28.0 (#1655) * testing configurations and plugins for babel Signed-off-by: ochikov <ognyan@limechain.tech> * bump up version Signed-off-by: ochikov <ognyan@limechain.tech> * babel options and exports Signed-off-by: ochikov <ognyan@limechain.tech> * options for babel and for properly building the SDK Signed-off-by: ochikov <ognyan@limechain.tech> * Fix/issue with encode decode (#1647) * refactor and add integration tests Signed-off-by: ochikov <ognyan@limechain.tech> * fix linter Signed-off-by: ochikov <ognyan@limechain.tech> * add ds store ignore Signed-off-by: ochikov <ognyan@limechain.tech> * remove the max attempts from commonJs tests Signed-off-by: ochikov <ognyan@limechain.tech> * change the mainnet topicId subscription in TopicMessageQuery integration test Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * fix exact version of grpc librart (#1652) Signed-off-by: ochikov <ognyan@limechain.tech> * remove ping all from the integration test env setup (#1650) Signed-off-by: ochikov <ognyan@limechain.tech> * changelog and version updated Signed-off-by: ochikov <ognyan@limechain.tech> * fix getting a random node when the list is not locked (#1654) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare for release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare stable release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Co-authored-by: ochikov <ognyan@limechain.tech> Co-authored-by: Ognyan Chikov <ochikov@users.noreply.github.com> * initial approach Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * improve grpc calls Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Co-authored-by: ochikov <ognyan@limechain.tech> Co-authored-by: Ognyan Chikov <ochikov@users.noreply.github.com> * prepare for release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare for release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Co-authored-by: ochikov <ognyan@limechain.tech> Co-authored-by: Ognyan Chikov <ochikov@users.noreply.github.com>
monokaijs
pushed a commit
to monostarter/u2u-sdk-js
that referenced
this pull request
Jul 5, 2023
* testing configurations and plugins for babel Signed-off-by: ochikov <ognyan@limechain.tech> * bump up version Signed-off-by: ochikov <ognyan@limechain.tech> * babel options and exports Signed-off-by: ochikov <ognyan@limechain.tech> * options for babel and for properly building the SDK Signed-off-by: ochikov <ognyan@limechain.tech> * Fix/issue with encode decode (hiero-ledger#1647) * refactor and add integration tests Signed-off-by: ochikov <ognyan@limechain.tech> * fix linter Signed-off-by: ochikov <ognyan@limechain.tech> * add ds store ignore Signed-off-by: ochikov <ognyan@limechain.tech> * remove the max attempts from commonJs tests Signed-off-by: ochikov <ognyan@limechain.tech> * change the mainnet topicId subscription in TopicMessageQuery integration test Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * fix exact version of grpc librart (hiero-ledger#1652) Signed-off-by: ochikov <ognyan@limechain.tech> * remove ping all from the integration test env setup (hiero-ledger#1650) Signed-off-by: ochikov <ognyan@limechain.tech> * changelog and version updated Signed-off-by: ochikov <ognyan@limechain.tech> * fix getting a random node when the list is not locked (hiero-ledger#1654) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare for release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare stable release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Co-authored-by: ochikov <ognyan@limechain.tech> Co-authored-by: Ognyan Chikov <ochikov@users.noreply.github.com>
monokaijs
pushed a commit
to monostarter/u2u-sdk-js
that referenced
this pull request
Jul 5, 2023
* testing configurations and plugins for babel Signed-off-by: ochikov <ognyan@limechain.tech> * bump up version Signed-off-by: ochikov <ognyan@limechain.tech> * babel options and exports Signed-off-by: ochikov <ognyan@limechain.tech> * options for babel and for properly building the SDK Signed-off-by: ochikov <ognyan@limechain.tech> * Fix/issue with encode decode (hiero-ledger#1647) * refactor and add integration tests Signed-off-by: ochikov <ognyan@limechain.tech> * fix linter Signed-off-by: ochikov <ognyan@limechain.tech> * add ds store ignore Signed-off-by: ochikov <ognyan@limechain.tech> * remove the max attempts from commonJs tests Signed-off-by: ochikov <ognyan@limechain.tech> * change the mainnet topicId subscription in TopicMessageQuery integration test Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * fix exact version of grpc librart (hiero-ledger#1652) Signed-off-by: ochikov <ognyan@limechain.tech> * remove ping all from the integration test env setup (hiero-ledger#1650) Signed-off-by: ochikov <ognyan@limechain.tech> * changelog and version updated Signed-off-by: ochikov <ognyan@limechain.tech> * fix getting a random node when the list is not locked (hiero-ledger#1654) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare for release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare stable release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * GRPC improvements (hiero-ledger#1656) * Release/v2.28.0 (hiero-ledger#1655) * testing configurations and plugins for babel Signed-off-by: ochikov <ognyan@limechain.tech> * bump up version Signed-off-by: ochikov <ognyan@limechain.tech> * babel options and exports Signed-off-by: ochikov <ognyan@limechain.tech> * options for babel and for properly building the SDK Signed-off-by: ochikov <ognyan@limechain.tech> * Fix/issue with encode decode (hiero-ledger#1647) * refactor and add integration tests Signed-off-by: ochikov <ognyan@limechain.tech> * fix linter Signed-off-by: ochikov <ognyan@limechain.tech> * add ds store ignore Signed-off-by: ochikov <ognyan@limechain.tech> * remove the max attempts from commonJs tests Signed-off-by: ochikov <ognyan@limechain.tech> * change the mainnet topicId subscription in TopicMessageQuery integration test Signed-off-by: ochikov <ognyan@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> * fix exact version of grpc librart (hiero-ledger#1652) Signed-off-by: ochikov <ognyan@limechain.tech> * remove ping all from the integration test env setup (hiero-ledger#1650) Signed-off-by: ochikov <ognyan@limechain.tech> * changelog and version updated Signed-off-by: ochikov <ognyan@limechain.tech> * fix getting a random node when the list is not locked (hiero-ledger#1654) Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare for release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare stable release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Co-authored-by: ochikov <ognyan@limechain.tech> Co-authored-by: Ognyan Chikov <ochikov@users.noreply.github.com> * initial approach Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * improve grpc calls Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Co-authored-by: ochikov <ognyan@limechain.tech> Co-authored-by: Ognyan Chikov <ochikov@users.noreply.github.com> * prepare for release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> * prepare for release Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> --------- Signed-off-by: ochikov <ognyan@limechain.tech> Signed-off-by: Petar Tonev <petar.tonev@limechain.tech> Co-authored-by: ochikov <ognyan@limechain.tech> Co-authored-by: Ognyan Chikov <ochikov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change the way the contract function params are encoded/decoded.
Related issue(s):
Fixes #1640
Notes for reviewer:
Checklist