Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: change or remove existing keys from a token [HIP-540] #2299

Conversation

svetoslav-nikol0v
Copy link
Contributor

@svetoslav-nikol0v svetoslav-nikol0v commented May 27, 2024

Description:

HIP-540 introduces new changes to TokenUpdateTransaction where the user will be able to remove keys that were initially set on the token.

Note:

The Hedera protobuf changes for this feature will be introduced in Hedera Services Release 0.50.0.
This PR contains the protobuf changes for the hip.

Related issue(s): #1735

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@svetoslav-nikol0v svetoslav-nikol0v requested review from a team as code owners May 27, 2024 11:24
@svetoslav-nikol0v svetoslav-nikol0v linked an issue May 27, 2024 that may be closed by this pull request
6 tasks
@svetoslav-nikol0v svetoslav-nikol0v changed the title feature: change or remove token keys feature: change or remove existing keys from a token May 27, 2024
@svetoslav-nikol0v svetoslav-nikol0v requested review from a team as code owners May 27, 2024 11:37
@svetoslav-nikol0v svetoslav-nikol0v changed the title feature: change or remove existing keys from a token feature: change or remove existing keys from a token [HIP-540] May 27, 2024
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
@svetoslav-nikol0v svetoslav-nikol0v force-pushed the 1735-add-hip-540-change-or-remove-existing-keys-from-a-token branch from d85ba1d to 99868e2 Compare June 13, 2024 12:44
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
69.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@svetoslav-nikol0v svetoslav-nikol0v merged commit 72f4656 into main Jun 14, 2024
8 of 9 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the 1735-add-hip-540-change-or-remove-existing-keys-from-a-token branch June 14, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HIP-540: Change Or Remove Existing Keys From A Token
3 participants