Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pull protobuf changes from latest tag #2398

Conversation

isavov
Copy link
Contributor

@isavov isavov commented Jul 12, 2024

Description:

This PR updates the proto:update task to use the latest semantic version tag instead of main as a reference in the upstream protobufs repo.

Related issue(s):

Fixes #2393

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…ag instead of main

Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
@isavov isavov requested review from a team as code owners July 12, 2024 07:17
@isavov isavov requested a review from rwalworth July 12, 2024 07:17
@isavov isavov self-assigned this Jul 12, 2024
isavov added 2 commits July 12, 2024 12:27
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
Signed-off-by: Iliya Savov <isavov@users.noreply.github.com>
@isavov isavov force-pushed the 2393-pull-protobuf-changes-from-release-tag-from-protobuf-centralized-repo-instead-of-main-branch branch from c367e0a to 2e82b52 Compare July 12, 2024 10:06
…from-protobuf-centralized-repo-instead-of-main-branch
Copy link

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @isavov

@svetoslav-nikol0v svetoslav-nikol0v merged commit a618bbb into main Jul 16, 2024
7 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the 2393-pull-protobuf-changes-from-release-tag-from-protobuf-centralized-repo-instead-of-main-branch branch July 16, 2024 13:19
@svetoslav-nikol0v svetoslav-nikol0v mentioned this pull request Aug 3, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull protobuf changes from release tag from protobuf centralized repo instead of main branch
3 participants