Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly set message end position to account for padding #458

Merged
merged 2 commits into from
Apr 29, 2019

Conversation

hierynomus
Copy link
Owner

No description provided.

@hierynomus
Copy link
Owner Author

This should fix #420.

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #458 into master will decrease coverage by <.01%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #458      +/-   ##
============================================
- Coverage     44.77%   44.77%   -0.01%     
- Complexity      888      890       +2     
============================================
  Files           229      229              
  Lines          6727     6734       +7     
  Branches        504      506       +2     
============================================
+ Hits           3012     3015       +3     
- Misses         3466     3467       +1     
- Partials        249      252       +3
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/hierynomus/mssmb2/SMB2Header.java 83.83% <100%> (+1.01%) 29 <0> (+1) ⬆️
...rc/main/java/com/hierynomus/smbj/common/Check.java 28.57% <33.33%> (+3.57%) 2 <1> (+1) ⬆️
...rc/main/java/com/hierynomus/mssmb2/SMB2Packet.java 73.91% <40%> (-4.66%) 14 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0803d4...46ec000. Read the comment docs.

@nddipiazza
Copy link
Contributor

nddipiazza commented Apr 29, 2019

These changes look good. I tested them on production data. What was failing before is now successful.

@hierynomus
Copy link
Owner Author

Yay! Going to merge it then.

@hierynomus hierynomus merged commit db7cba6 into master Apr 29, 2019
@hierynomus hierynomus deleted the issue-420 branch April 29, 2019 21:35
@nddipiazza
Copy link
Contributor

Thanks! Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants