Add support for multiple entries in known hosts #406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue#405 - similar to openssh, add support for attempting to verify host keys by trying all entries in known_hosts, instead of bailing out on the first failure. This is because there could be multiple entries for a host, and only one/some of them may be valid.
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
============================================
+ Coverage 55.22% 55.39% +0.17%
- Complexity 1148 1151 +3
============================================
Files 189 189
Lines 7482 7486 +4
Branches 652 653 +1
============================================
+ Hits 4132 4147 +15
+ Misses 3001 2991 -10
+ Partials 349 348 -1
Continue to review full report at Codecov.
|
|
Did some refactoring on this PR, closing the original one. |
|
Thanks @hierynomus - a release would be great ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#405 - similar to openssh, add support for attempting to verify
host keys by trying all entries in known_hosts, instead of bailing out
on the first failure. This is because there could be multiple entries for
a host, and only one/some of them may be valid.
Couple of notes:
Exceptionclass in theOpenSSHKnownHostsconstructor to continue with the rest of the file in case of other runtime exceptions (e.g. inability to base64 decode a line - covered by tests)known_hostsfile to successfully validate multiple entries for the same host (where only one entry is valid)