Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated proxy connect methods from SocketClient #756

Merged

Conversation

exceptionfactory
Copy link
Contributor

This pull request removes deprecated connect() methods from SocketClient that support connections through a proxy server. As described in comments, proxy support can be implemented using a custom implementation of the standard Java SocketFactory.

The deprecated method comments indicated that these methods would be removed after version 0.12.0. Removing these deprecated methods provided the opportunity to remove the custom Jdk7HttpProxySocket class and the associated JavaVersion class.

@hierynomus
Copy link
Owner

Actually not entirely correct, we still support Java7 for the rare enterprise case, so even for a SocketFactory you would need the custom Jdk7HttpProxySocket.

@exceptionfactory
Copy link
Contributor Author

Thanks for the feedback @hierynomus! What do you think about removing the connect methods, but retaining the Jdk7HttpProxySocket class?

@exceptionfactory
Copy link
Contributor Author

@hierynomus, following up on this, do you want to remove the deprecated connect() methods that accept Proxy parameters? If not, I can close this pull request.

@hierynomus
Copy link
Owner

Yes, was about to merge this one actually ;)

@exceptionfactory
Copy link
Contributor Author

Sounds good, thanks!

@hierynomus hierynomus merged commit 50efeb6 into hierynomus:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants