Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to gradle 7.6.1 to make JDK 17+ work #860

Merged
merged 1 commit into from
May 22, 2023

Conversation

kajtzu
Copy link
Contributor

@kajtzu kajtzu commented May 22, 2023

Please accept this trivial patch to upgrade Gradle 7.0 -> 7.6.1.

Compiling with JDK 17 (LTS) does not work with 7.0 but would require at least 7.3.

I chose to upgrade to latest and greatest to allow compilation also on more recent JDKs 18, 19 according to this https://docs.gradle.org/current/userguide/compatibility.html

@kajtzu kajtzu requested a review from hierynomus as a code owner May 22, 2023 09:58
@codecov-commenter
Copy link

Codecov Report

Merging #860 (8f3c001) into master (0d16fbe) will increase coverage by 0.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #860      +/-   ##
============================================
+ Coverage     65.06%   65.29%   +0.23%     
- Complexity     1433     1438       +5     
============================================
  Files           209      209              
  Lines          8061     8060       -1     
  Branches        752      746       -6     
============================================
+ Hits           5245     5263      +18     
+ Misses         2409     2401       -8     
+ Partials        407      396      -11     

see 13 files with indirect coverage changes

@kajtzu
Copy link
Contributor Author

kajtzu commented May 22, 2023

Please LMK if you need a CLA or similar.

@hierynomus hierynomus merged commit 233c0dc into hierynomus:master May 22, 2023
@kajtzu kajtzu deleted the upgrade-gradle-for-jdk17 branch May 22, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants