Add unit tests of strict key exchange extension #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpoettker
force-pushed
the
terrapin-unit-test
branch
from
8302bd7
to
eb5282e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #918 +/- ##
============================================
+ Coverage 68.74% 69.02% +0.27%
- Complexity 1437 1448 +11
============================================
Files 208 208
Lines 7602 7602
Branches 658 658
============================================
+ Hits 5226 5247 +21
+ Misses 2023 2004 -19
+ Partials 353 351 -2 ☔ View full report in Codecov by Sentry. |
hpoettker
force-pushed
the
terrapin-unit-test
branch
from
eb5282e
to
588ab70
Compare
hpoettker
force-pushed
the
terrapin-unit-test
branch
from
588ab70
to
12ea6b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for merging #917!
I also wrote two unit tests for the
KeyExchangerand theTransport, respectively. They cover some corner cases and in particular aborts that are an import part of the strict key exchange to address the CVE. However, they are a bit mock and reflection heavy, so they might show brittleness in the future.