Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom apt-daily and apt-daily-upgrade timers #120

Merged
merged 22 commits into from
Jun 6, 2023
Merged

Add support for custom apt-daily and apt-daily-upgrade timers #120

merged 22 commits into from
Jun 6, 2023

Conversation

pgassmann
Copy link
Contributor

@pgassmann pgassmann commented May 31, 2023 •
edited
Loading

Restore of #86 by @mabed-fr

with additional fixes and improvements based on the feedback on the original PR.

Mathieu BEDOS and others added 17 commits May 31, 2023 17:10
@pgassmann
add-possibility-to-custom-timers--85
7f13242
@pgassmann
Edit-README--85
a8d0825
@pgassmann
Set default debian value
7575a78
@pgassmann
ensure direcotry exist
3a890e9
@pgassmann
ensure direcotry exist
31dad35
@pgassmann
lint & quoted values
2ddf948
@mabed-fr @christianhueserhzdr @pgassmann
Update README.md
9f363df 
Co-authored-by: Christian Hueser <55481699+christianhueserhzdr@users.noreply.github.com>
@mabed-fr @christianhueserhzdr @pgassmann
Update README.md
b125428 
Co-authored-by: Christian Hueser <55481699+christianhueserhzdr@users.noreply.github.com>
@mabed-fr @christianhueserhzdr @pgassmann
Update tasks/systemd_timers.yml
d81d97a 
Co-authored-by: Christian Hueser <55481699+christianhueserhzdr@users.noreply.github.com>
@mabed-fr @christianhueserhzdr @pgassmann
Update tasks/systemd_timers.yml
4ab7fc2 
Co-authored-by: Christian Hueser <55481699+christianhueserhzdr@users.noreply.github.com>
@mabed-fr @christianhueserhzdr @pgassmann
Update README.md
82d8198 
Co-authored-by: Christian Hueser <55481699+christianhueserhzdr@users.noreply.github.com>
@mabed-fr @christianhueserhzdr @pgassmann
Update README.md
dba0f3c 
Co-authored-by: Christian Hueser <55481699+christianhueserhzdr@users.noreply.github.com>
@mabed-fr @christianhueserhzdr @pgassmann
Update tasks/systemd_timers.yml
eefe42d 
Co-authored-by: Christian Hueser <55481699+christianhueserhzdr@users.noreply.github.com>
@mabed-fr @christianhueserhzdr @pgassmann
Update tasks/systemd_timers.yml
5d5c47a 
Co-authored-by: Christian Hueser <55481699+christianhueserhzdr@users.noreply.github.com>
@mabed-fr @christianhueserhzdr @pgassmann
Update tasks/systemd_timers.yml
82731ea 
Co-authored-by: Christian Hueser <55481699+christianhueserhzdr@users.noreply.github.com>
@mabed-fr @christianhueserhzdr @pgassmann
Update tasks/systemd_timers.yml
8e1522a 
Co-authored-by: Christian Hueser <55481699+christianhueserhzdr@users.noreply.github.com>
@pgassmann
optional override, improvements, docs
7884b0d 
based on feedback on !86
@pgassmann pgassmann marked this pull request as ready for review May 31, 2023 15:13
@pgassmann pgassmann requested a review from a team as a code owner May 31, 2023 15:13
@Normo Normo self-assigned this Jun 1, 2023
@pgassmann
Copy link
Contributor Author

@christianhueserhzdr You reviewed the orignal PR from which I incorporated your feedback. Can you check the changes I did?

@Normo Normo added this to the v3.1.0 milestone Jun 5, 2023
@Normo Normo linked an issue Jun 5, 2023 that may be closed by this pull request
Added custom of apt-daily timers apt-daily-upgrade #85
Closed
Normo
Normo requested changes Jun 5, 2023
View reviewed changes
Copy link
Member

@Normo Normo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @pgassmann! I made a few suggestions that should be implemented before we can merge it.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
defaults/main.yml Outdated Show resolved Hide resolved
templates/apt_daily_override.conf.j2 Outdated Show resolved Hide resolved
templates/apt_daily_upgrade_override.conf.j2 Outdated Show resolved Hide resolved
tasks/main.yml Outdated Show resolved Hide resolved
tasks/systemd_timers.yml Outdated Show resolved Hide resolved
tasks/systemd_timers.yml Outdated Show resolved Hide resolved
tasks/systemd_timers.yml Outdated Show resolved Hide resolved
tasks/systemd_timers.yml Outdated Show resolved Hide resolved
@Normo Normo added the enhancement New feature or request label Jun 5, 2023
@pgassmann
Copy link
Contributor Author

@Normo I implemented your suggestions: ef85676

pgassmann
pgassmann commented Jun 5, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
Normo
Normo reviewed Jun 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
Normo
Normo reviewed Jun 6, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Normo
Normo approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@Normo Normo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pgassmann

@Normo Normo changed the title Add-possibility-to-custom-timers Add support for custom apt-daily and apt-daily-upgrade timers Jun 6, 2023
@Normo Normo merged commit f393e28 into hifis-net:main Jun 6, 2023
@Normo Normo mentioned this pull request Jun 8, 2023
Merged
@Normo Normo removed the enhancement New feature or request label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Normo Normo Normo approved these changes

Assignees

@Normo Normo

Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

Added custom of apt-daily timers apt-daily-upgrade
3 participants
@pgassmann @Normo @mabed-fr