Test custom apt-daily timers #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normo
changed the title
Normo
force-pushed
the
test-custom-timers
branch
4 times, most recently
from
0573e41 to
dd2e202
Compare
Signed-off-by: Norman Ziegner <norman.ziegner@ufz.de>
Normo
changed the title
tobiashuste
reviewed
Jun 8, 2023
There was a problem hiding this comment.
Thanks for taking care of testing the new feature. This looks all fine. I wonder if it makes sense to test the other way round as well. My idea was as follows:
- Introduce a second test instance similar to the first one
- Only configure the timer related variables with
instance2 - Make sure to only verify timers if
unattended_systemd_timer_overrideistrue.
This way we could also cover the case that we do not reach that part of the code. Do you think that is necessary?
|
Good point. I think this will result in some more rebuilding of |
tobiashuste
approved these changes
Jun 8, 2023
This was referenced May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for custom apt-daily timers to the Molecule verify step. This is a follow-up for #120