Added Morningstar to HC namespace. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelfus
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Missing:
- docs update (eg https://github.com/highcharts/connectors-morningstar/blob/main/docs/connectors/morningstar/risk-score.md )
- demos updated (related PR in Core repository)
|
Additional request: |
pawelfus
approved these changes
Nov 14, 2024
pawelfus
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Prematurely accepted.. the tests are failing.
[10:49:03] Start XRay/Breakdown tests ...
[10:49:03] Test breakdown load ... ❌ ERROR.
AssertionError [ERR_ASSERTION]: Connector table should have the expected amount of rows.
at breakdownLoad (/Users/pawelfus/Projects/connectors-morningstar/tests/XRay/Breakdown.test.ts:48:12)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at async runUnitTests (/Users/pawelfus/Projects/connectors-morningstar/tools/tests.ts:165:21) {
generatedMessage: false,
code: 'ERR_ASSERTION',
actual: false,
expected: true,
operator: '=='
}
|
@pawelfus , tests should be fine right now. All good on my side 👍 |
TorsteinHonsi
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
HighchartsConnectors.Morningstarinstead ofConnectors.Morningstar.Related HC PR highcharts/highcharts#22154