Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/investment screener #52

Merged
merged 18 commits into from
Nov 29, 2024
Merged

Feature/investment screener #52

merged 18 commits into from
Nov 29, 2024

Conversation

pawellysy
Copy link
Member

No description provided.

DJTechnoo
DJTechnoo reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@DJTechnoo DJTechnoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Could you update the demos/index.html file and list the demo there too?

@DJTechnoo DJTechnoo self-requested a review November 26, 2024 08:56
DJTechnoo
DJTechnoo requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@DJTechnoo DJTechnoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path not found because of typo

demos/index.html Outdated Show resolved Hide resolved
@pawellysy pawellysy requested a review from DJTechnoo November 26, 2024 10:34
pawelfus
pawelfus requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a minor polishing:

  • Docs are missing (see docs/connectors/*.md for inspiration). It seems you created src/Screeners/../README.md file but is missing most of the content.
  • Add some comments to the demo.js file. Start with desc for functions and filters

@bre1470
Copy link
Member

bre1470 commented Nov 27, 2024

One thing: Add the options to api.d.ts.

@pawellysy pawellysy requested a review from pawelfus November 28, 2024 06:59
pawelfus
pawelfus requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple more things:

  1. Missing link in the main index:
image
  1. The doc itself looks strange. Wrong formatting in both, preview and http://localhost:8000/morningstar/screeners/investment-screener.md
Zrzut ekranu 2024-11-28 o 12 28 39

@pawellysy pawellysy requested a review from pawelfus November 28, 2024 13:54
@pawelfus pawelfus added this to the Next milestone Nov 28, 2024
pawelfus
pawelfus requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • conflicts
  • typo this -> This

@pawelfus pawelfus modified the milestones: v0.7.0, v1.0.0 Nov 28, 2024
TorsteinHonsi
TorsteinHonsi approved these changes Nov 28, 2024
View reviewed changes
Copy link

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@pawellysy pawellysy force-pushed the feature/investment-screener branch from 533fdb3 to dcda7a7 Compare November 29, 2024 09:06
pawelfus
pawelfus approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@pawelfus pawelfus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pawelfus pawelfus merged commit a9ef98d into main Nov 29, 2024
5 checks passed
@pawelfus pawelfus deleted the feature/investment-screener branch November 29, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil-musialowski kamil-musialowski kamil-musialowski approved these changes

@bm64 bm64 bm64 approved these changes

@bre1470 bre1470 bre1470 approved these changes

@DJTechnoo DJTechnoo DJTechnoo approved these changes

@pawelfus pawelfus pawelfus approved these changes

@TorsteinHonsi TorsteinHonsi TorsteinHonsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@pawellysy @bre1470 @TorsteinHonsi @pawelfus @DJTechnoo @bm64 @kamil-musialowski