This repository has been archived by the owner on May 29, 2018. It is now read-only.
Adds new option exporting.csv.dataFormatter #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the default number format for HTML data table and exported CSV
historicbruno
force-pushed
the
add-dataformatter-option
branch
from
3d41eba to
19893e1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added this option, which allows overriding the default number format for HTML data table and exported CSV. It shouldn't change the existing default behavior, and I didn't change the strange way the local decimal point is detected (I think it could be changed pretty easily, if needed).
Also, it might be sensible to have separate formatter functions for CSV and HTML table, but this is only a single option for both.