Skip to content
This repository has been archived by the owner on May 29, 2018. It is now read-only.

Honor chart.options.exporting.fallbackToExportServer flag. #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Honor chart.options.exporting.fallbackToExportServer flag. #129

wants to merge 2 commits into from

Conversation

tdibacco
Copy link

Added code to honor chart.options.exporting.fallbackToExportServer flag.

Reference
http://api.highcharts.com/highcharts/exporting.fallbackToExportServer

Copy link
Contributor

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fallbackToExportServer option is undefined by default. You should probably do a strict test in case it is not set:
if (chart.options.exporting.fallbackToExportServer !== false)

@tdibacco
Copy link
Author

tdibacco commented Apr 26, 2017

TorsteinHonsi, Thanks for the review. I updated the PR with the strict check.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants