#393 - highcharts ssr compatibility angular #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karolkolodziej
requested changes
Dec 6, 2024
| @@ -23,10 +24,18 @@ export class HighchartsChartComponent implements OnDestroy, OnChanges { | |||
|
|
|||
| constructor( | |||
| private el: ElementRef, | |||
| private _zone: NgZone // #75 | |||
| private _zone: NgZone, // #75 | |||
| private @Inject(PLATFORM_ID) platformId: Object, | |||
There was a problem hiding this comment.
Suggested change
| private @Inject(PLATFORM_ID) platformId: Object, | |
| @Inject(PLATFORM_ID) private platformId: Object |
| ngOnChanges(changes: SimpleChanges): void { | ||
| this.ssrCompatible(); |
There was a problem hiding this comment.
This won't work. You need to make it like this:
ngOnChanges(changes: SimpleChanges): void {
if (this.ssrCompatible()) {
return;
}
...
PowerKiKi
reviewed
Dec 6, 2024
| import type * as Highcharts from 'highcharts'; | ||
| import type HighchartsESM from 'highcharts/es-modules/masters/highcharts.src'; | ||
| import { isplatFormServer } from '@angular/common'; |
There was a problem hiding this comment.
Suggested change
| import { isplatFormServer } from '@angular/common'; | |
| import { isPlatformServer } from '@angular/common'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#393 - highcharts ssr compatibility angular
The documentation should also be updated for the same. There is no if condition needed, it will simply work for SSR.