Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabletIcon is not defined #202

Open
slavede opened this issue Nov 19, 2019 · 0 comments · May be fixed by #203
Open

tabletIcon is not defined #202

slavede opened this issue Nov 19, 2019 · 0 comments · May be fixed by #203

Comments

@slavede
Copy link

slavede commented Nov 19, 2019

Expected behaviour

Syntac to be correct

Actual behaviour

When transpiled, minified and uglified code, highcharts-editor.js throws and error

ReferenceError: tabletIcon is not defined

which makes perfect sense when you look at the source of src/core-ui/highed.customizepage.js

151 | phoneIcon = highed.dom.cr('span', '', '');
152 | tabletIcon = highed.dom.cr('span', '', ''),
153 | tabletIcon = highed.dom.cr('span', '', ''),

Notice ';' after phoneIcon. It should be comma.

Reproduction steps

Editor version

0.3.0

Affected browser(s)

slavede added a commit to slavede/highcharts-editor that referenced this issue Nov 19, 2019
slavede added a commit to slavede/highcharts-editor that referenced this issue Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant