Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change implicit StreamObserver conversions to syntax #157

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

peterneyens
Copy link
Contributor

Small internal cleanup

  • Conversions between StreamObserver and Monix / reactive streams Subscribers are now syntax methods instead of implicit conversions.
  • Introduce transformStreamObserver.

- Conversions between `StreamObserver` and Monix / reactive streams `Subscriber`s
  are now syntax methods instead of implicit conversions.
- Introduce `transformStreamObserver`.
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements, thanks!

@codecov-io
Copy link

Codecov Report

Merging #157 into master will decrease coverage by 4.72%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   92.65%   87.93%   -4.73%     
==========================================
  Files          30       30              
  Lines         286      290       +4     
  Branches        6        7       +1     
==========================================
- Hits          265      255      -10     
- Misses         21       35      +14
Impacted Files Coverage Δ
...es/internal/src/main/scala/server/monixCalls.scala 80% <100%> (-4.22%) ⬇️
...odules/internal/src/main/scala/MonixAdapters.scala 80% <100%> (ø) ⬆️
...dules/internal/src/main/scala/server/package.scala 77.77% <100%> (+2.77%) ⬆️
...ules/internal/src/main/scala/server/fs2Calls.scala 85.71% <100%> (-7.15%) ⬇️
...dules/internal/src/main/scala/client/package.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04783ca...1c9b4c4. Read the comment docs.

@juanpedromoreno juanpedromoreno merged commit 8610a8e into master Jan 31, 2018
@juanpedromoreno juanpedromoreno deleted the explicit-streamobserver-conversions branch January 31, 2018 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants