Adds additional server definitions tests #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpedromoreno
force-pushed
the
jp-server-defs-tests-part-2
branch
from
b3ebcda to
55bb9d2
Compare
juanpedromoreno
force-pushed
the
jp-server-defs-tests-part-2
branch
from
55bb9d2 to
77198b3
Compare
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
===========================================
+ Coverage 34.78% 48.93% +14.15%
===========================================
Files 7 8 +1
Lines 46 47 +1
===========================================
+ Hits 16 23 +7
+ Misses 30 24 -6
Continue to review full report at Codecov.
|
| "work as expected" in { | ||
|
|
||
| val configList: List[GrpcConfig] = List(AddService(sd1)) | ||
| val server: Server = SServerBuilder(port).withGrpcConfigList(configList).buildServer |
There was a problem hiding this comment.
Why not just:
SServerBuilder(port, configList)There was a problem hiding this comment.
Because this test is covering withGrpcConfigList branch ;)
|
|
||
| val serverF = BuildServerFromConfig[ServerConfig.Op]("rpc.server.port").interpret[Future] | ||
|
|
||
| serverF map (_.getPort shouldBe port) |
There was a problem hiding this comment.
Because this is a Future, this test is not verifying the value. I've tried different values for port and it succeeds for all of them
|
|
||
| "load the default port when the config port path is not found" in { | ||
|
|
||
| val serverF = BuildServerFromConfig[ServerConfig.Op]("rpc.wrong.path").interpret[Future] |
juanpedromoreno
force-pushed
the
jp-server-defs-tests-part-2
branch
from
193d7bf to
43ab1ec
Compare
juanpedromoreno
force-pushed
the
jp-server-defs-tests-part-2
branch
from
43ab1ec to
2e528e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes #15
Now, rpc server module reaches almost the 100% of test coverage. In the next PRs I'll cover the client definition tests.
Please, @fedefernandez could you take a look? Thanks!