Adds tests for some client handlers #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedefernandez
approved these changes
Jul 6, 2017
|
|
||
| trait RpcBaseTestSuite extends WordSpec with Matchers with OneInstancePerTest with MockFactory { | ||
|
|
||
| sealed trait Syntax { |
There was a problem hiding this comment.
It's not a big thing, I marked as sealed because it's already associated with the Helper trait below, being sealed it's not composable in other ways outside of this file.
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 13.85% 18.07% +4.21%
==========================================
Files 12 12
Lines 166 166
Branches 1 1
==========================================
+ Hits 23 30 +7
+ Misses 143 136 -7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, restructures the test suite classes to use them across client and server tests.
Related to #24