replace all occurrences of @tagless annotation with the manual impl #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, most of the implementaitions only needed the `Handler[F]` type in the companion.
diesalbla
approved these changes
Jun 4, 2018
|
|
||
| object GrpcServer { | ||
|
|
||
| trait Handler[G[_]] extends GrpcServer[G] |
There was a problem hiding this comment.
In the @tagless macro of freestyle, the Handler alias is useful only if you use the stacksafe option, in which case the Handler is both the algebra and an interpreter (natural transformation) from the Op type, used in the free algebra.
If you do not use the Op classes, or a Free encoding, you can get rid of the Handler, since it adds nothing.
There was a problem hiding this comment.
Cool, thanks for the tip! Changing it
diesalbla
reviewed
Jun 4, 2018
|
|
||
| object TodoListClient { | ||
| trait Handler[G[_]] extends TodoListClient[G] |
There was a problem hiding this comment.
Same as in my other comment.
|
|
||
| object TodoItemClient { | ||
| trait Handler[G[_]] extends TodoItemClient[G] |
There was a problem hiding this comment.
Same as in my other comment.
| @@ -36,3 +34,7 @@ trait TagClient[F[_]] { | |||
| def remove(id: Int): F[Int] | |||
|
|
|||
| } | |||
|
|
|||
| object TagClient { | |||
| trait Handler[G[_]] extends TagClient[G] | |||
| trait PingPongClient[F[_]] { | ||
| def ping(): F[Unit] | ||
| } | ||
|
|
||
| object PingPongClient { | ||
| trait Handler[G[_]] extends PingPongClient[G] |
| trait RouteGuideClient[F[_]] { | ||
| def getFeature(lat: Int, lon: Int): F[Unit] | ||
| def listFeatures(lowLat: Int, lowLon: Int, hiLat: Int, hiLon: Int): F[Unit] | ||
| def recordRoute(features: List[Feature], numPoints: Int): F[Unit] | ||
| def routeChat: F[Unit] | ||
| } | ||
|
|
||
| object RouteGuideClient { | ||
| trait Handler[G[_]] extends RouteGuideClient[G] |
| @@ -165,6 +163,14 @@ object Utils extends CommonUtils { | |||
| def bsws(eList: List[E]): F[E] | |||
| } | |||
|
|
|||
| object MyRPCClient { | |||
|
|
|||
| trait Handler[G[_]] extends MyRPCClient[G] | |||
juanpedromoreno
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, most of the implementaitions only needed theNot even that :)Handler[F]type in the companion.
FIXES #292