Updates docs with the custom codecs section #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpedromoreno
approved these changes
Jul 31, 2018
juanpedromoreno
approved these changes
Aug 2, 2018
docs/src/main/tut/core-concepts.md
Outdated
| @@ -392,6 +392,14 @@ It also provides the instances for `org.joda.time.LocalDate` and `org.joda.time. | |||
| * `import freestyle.rpc.marshallers.jodaTimeEncoders.pbd._` | |||
| * `org.joda.time.LocalDate` and `org.joda.time.LocalDateTime` in `Avro` | |||
| * `import freestyle.rpc.marshallers.jodaTimeEncoders.avro._` | |||
|
|
|||
| **Note**: If you want to send one of these instances directly as a request or response through Avro, you need to provide an instance of `Marshaller`. [frees-rpc] provides the marshallers for `BigDecimal`, `LocalDate`, `LocalDateTime`, `org.joda.time.LocalDate` and `org.joda.time.LocalDateTime` in a separated package: | |||
There was a problem hiding this comment.
I would add fully qualified names in all the cases, for example: java.time.LocalDate
docs/src/main/tut/core-concepts.md
Outdated
| **Note**: If you want to send one of these instances directly as a request or response through Avro, you need to provide an instance of `Marshaller`. [frees-rpc] provides the marshallers for `BigDecimal`, `LocalDate`, `LocalDateTime`, `org.joda.time.LocalDate` and `org.joda.time.LocalDateTime` in a separated package: | ||
| * `BigDecimal` in `Avro` | ||
| * `import freestyle.rpc.internal.encoders.avro.bigDecimal.marshallers._` | ||
| * `LocalDate` and `LocalDateTime` in `Avro` |
| @@ -22,7 +22,7 @@ import org.joda.time._ | |||
|
|
|||
| object JodaTimeUtil { | |||
|
|
|||
| private[this] val initialDate = DateTime.now(DateTimeZone.UTC).withMillis(0) | |||
| private[this] val initialDate = new DateTime(0, DateTimeZone.UTC) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And moves the marshaller instances to its own object.