Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows Custom namespace for server/client metrics #385

Merged

Conversation

juanpedromoreno
Copy link
Member

This PR allows providing externally the namespace for the registered metrics. Example:

val configList: List[ManagedChannelConfig] =
        AddInterceptor(
          MonitoringClientInterceptor(
            Configuration
              .defaultAllMetrics
              .withCollectorRegistry(CR)
              .withNamespace("custom_namespace")
          )
        )

.withNamespace("custom_namespace") is the combinator added here. If it's not provided, by default will be grpc, the same used until now.

@L-Lavigne L-Lavigne assigned L-Lavigne and unassigned L-Lavigne Sep 24, 2018
@L-Lavigne L-Lavigne self-requested a review September 24, 2018 22:00
Copy link
Contributor

@L-Lavigne L-Lavigne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! 👍

@juanpedromoreno juanpedromoreno merged commit a5a5ad9 into master Sep 25, 2018
@juanpedromoreno juanpedromoreno deleted the jp-allows-providing-metrics-namespace-externally branch September 25, 2018 05:11
@AdrianRaFo
Copy link
Contributor

@juanpedromoreno it would be possible get the project name and add it to the default namespace?

@juanpedromoreno
Copy link
Member Author

Frees-rpc users could do it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants