Migration guide for decimals #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It adds the legacy modules for ease client adoption
fedefernandez
commented
Oct 2, 2018
| private val adtGenerator = mainGenerator.copy(avroScalaCustomTypes = | ||
| Some(AvroScalaTypes.defaults.copy(protocol = ScalaADT))) // ScalaADT: sealed trait hierarchies | ||
| private val adtGenerator = mainGenerator.copy(avroScalaCustomTypes = Some( | ||
| mainGenerator.avroScalaTypes.copy(protocol = ScalaADT))) // ScalaADT: sealed trait hierarchies |
There was a problem hiding this comment.
Maybe I should create a small PR against master to fix this.
fedefernandez
force-pushed
the
ff/decimal-migration-guide
branch
from
e9947df to
c2359a7
Compare
fedefernandez
changed the title
juanpedromoreno
approved these changes
Oct 3, 2018
|
@juanpedromoreno I've added the disclaimer in the migration guide and removed the |
fedefernandez
force-pushed
the
ff/decimal-migration-guide
branch
from
c7918fe to
51f6dbf
Compare
juanpedromoreno
approved these changes
Oct 4, 2018
cb372
added a commit
that referenced
this pull request
Apr 24, 2020
These were added in #412 to aid migration due to a change in v0.15.1. This was way back in 2018, before Mu was even called Mu. I think people have had enough time to migrate by now.
2 tasks
cb372
added a commit
that referenced
this pull request
Apr 24, 2020
* Delete unused class * Remove the legacy-avro-decimal-compat modules These were added in #412 to aid migration due to a change in v0.15.1. This was way back in 2018, before Mu was even called Mu. I think people have had enough time to migrate by now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the needed modules for ease the migration to the new decimal serializers.
Added a new doc page, not sure if I need to list it in any place.
I've also finished the repository with the example: