Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up gRPC version #487

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Bump up gRPC version #487

merged 1 commit into from
Dec 14, 2018

Conversation

juanpedromoreno
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #487 into master will decrease coverage by 10.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #487       +/-   ##
==========================================
- Coverage   75.32%   65.2%   -10.12%     
==========================================
  Files          61      61               
  Lines         851     983      +132     
  Branches       14      14               
==========================================
  Hits          641     641               
- Misses        210     342      +132

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a885fb...e092eb8. Read the comment docs.

@fedefernandez
Copy link
Contributor

scalapb seems updated in master but not released. fs2-grpc is using the 1.15.x version, do you think this could be a problem?

@juanpedromoreno
Copy link
Member Author

@fedefernandez Anyway we are on 1.16.x, which will cause also an eviction with the scalapb version. I've asked for a new release in gitter though: https://gitter.im/trueaccord/ScalaPB?at=5c137b41ca317a0e25c59b4e

@juanpedromoreno juanpedromoreno merged commit de9462f into master Dec 14, 2018
@juanpedromoreno juanpedromoreno deleted the jp-upgrade-grpc branch December 14, 2018 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants