Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes some warnings #488

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Removes some warnings #488

merged 2 commits into from
Dec 14, 2018

Conversation

fedefernandez
Copy link
Contributor

Specially the ones in the macro are a bit annoying

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #488 into master will decrease coverage by 10.11%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #488       +/-   ##
===========================================
- Coverage   75.05%   64.94%   -10.12%     
===========================================
  Files          61       61               
  Lines         854      987      +133     
  Branches       17       17               
===========================================
  Hits          641      641               
- Misses        213      346      +133
Impacted Files Coverage Δ
modules/server/src/main/scala/package.scala 0% <0%> (ø) ⬆️
...idlgen/core/src/main/scala/IdlGenApplication.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598ad24...ae96eda. Read the comment docs.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fedefernandez fedefernandez merged commit 8ad2fb8 into master Dec 14, 2018
@fedefernandez fedefernandez deleted the ff/clean-up-warnings branch December 14, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants