Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the client extends the service #493

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

fedefernandez
Copy link
Contributor

@fedefernandez fedefernandez commented Dec 17, 2018

Go from this
screenshot 2018-12-14 at 18 42 17

To this
screenshot 2018-12-14 at 18 42 26

The problems:

  • We can't have nonrequest methods. Not a big deal, I haven't seen rpc services with custom methods.
  • The autogenerated clients are not AbstractStub from the user perspective. They can always make a casting. If this can be a problem, one alternative could be this [WIP] - Approach II #492

Thoughts?

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me despite the drawbacks ;) , since none of them would suppose a big stopper for the users.

Thanks @fedefernandez !

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #493 into master will decrease coverage by 10.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   74.97%   64.87%   -10.1%     
==========================================
  Files          61       61              
  Lines         855      988     +133     
  Branches       17       17              
==========================================
  Hits          641      641              
- Misses        214      347     +133
Impacted Files Coverage Δ
modules/client-netty/src/main/scala/netty.scala 0% <0%> (ø) ⬆️
...idlgen/core/src/main/scala/SrcGenApplication.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad2fb8...599a5d9. Read the comment docs.

Copy link
Contributor

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to get rid of all those false positives in IntelliJ :)

@fedefernandez fedefernandez merged commit c246d7a into master Dec 17, 2018
@fedefernandez fedefernandez deleted the ff/intellij-false-positives branch December 17, 2018 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants