Passes the method info to the MetricsOps defs #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesiloniz
approved these changes
Jan 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
=======================================
Coverage 81.42% 81.42%
=======================================
Files 64 64
Lines 985 985
Branches 19 17 -2
=======================================
Hits 802 802
Misses 183 183
Continue to review full report at Codecov.
|
jdesiloniz
approved these changes
Jan 18, 2019
juanpedromoreno
approved these changes
Jan 18, 2019
|
|
||
| def recordTotalTime( | ||
| method: MethodType, |
There was a problem hiding this comment.
Is the MethodType part of the GrpcMethodInfo?
There was a problem hiding this comment.
Then maybe we can remove MethodType from the declaration?
There was a problem hiding this comment.
yeah, I'm almost sure this is what I did 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.