Removes the compatibility of Monix.Observable in the HTTP layer #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
=======================================
Coverage 82.36% 82.36%
=======================================
Files 62 62
Lines 964 964
Branches 12 12
=======================================
Hits 794 794
Misses 170 170Continue to review full report at Codecov.
|
juanpedromoreno
approved these changes
Apr 2, 2019
| @@ -48,25 +44,21 @@ class GreeterRestTests extends RpcBaseTestSuite with BeforeAndAfter { | |||
| val Fs2ServicePrefix = "Fs2Greeter" | |||
| val MonixServicePrefix = "MonixGreeter" | |||
|
|
|||
| implicit val ec = monix.execution.Scheduler.Implicits.global | |||
| implicit val ec = scala.concurrent.ExecutionContext.Implicits.global | |||
There was a problem hiding this comment.
Do you know who requires an implicit ExecutionContext? With the ContextShift it shouldn't be necessary to be implicit.
There was a problem hiding this comment.
Merged. I’m clarifying this in my current branch. Thanks.
fedefernandez
approved these changes
Apr 2, 2019
rafaparadela
deleted the
feature/574-remove-Observable-compatibility-in-HTTP
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just this. Close #574