Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mmm/605 docs #625

Merged
merged 3 commits into from
Jul 10, 2019
Merged

Mmm/605 docs #625

merged 3 commits into from
Jul 10, 2019

Conversation

ememmr
Copy link
Contributor

@ememmr ememmr commented Jul 9, 2019

What this does?

Changes in documentation (issue #605):

  • index.md:
    Libraries version updated
    Old artifacts dropped
    Artifacts separated by use

-metrics-reporting.md:
References to JMX reporter added
References to 47deg blog’s article added (for me, the best help)

-patterns.md:
References to 47deg blog’s article added

-ssl-tls.md:
References to 47deg blog’s article added

At first I thought it would be better to add more examples in metrics-reporting section, but after reading those blog's articles, I think these articles are the best help.

mrtmmr added 2 commits July 9, 2019 10:24
Changes in documentation:

- index.md:
libraries version updated
Old artifacts dropped
Artifacts separated by use

-metrics-reporting.md:
References to JMX reporter added
References to 47deg blog’s articles added (for me, the best help)

-patterns.md:
References to 47deg blog’s articles added

-ssl-tls.md:
References to 47deg blog’s articles added
Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks!

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #625 into master will decrease coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage   82.86%   82.45%   -0.42%     
==========================================
  Files          62       62              
  Lines         969      969              
  Branches       11       11              
==========================================
- Hits          803      799       -4     
- Misses        166      170       +4
Impacted Files Coverage Δ
...kindness/mu/rpc/idlgen/avro/AvroSrcGenerator.scala 73.68% <0%> (-7.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ed88b...fd6e493. Read the comment docs.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrtmmr !

@ememmr ememmr merged commit dce6b79 into master Jul 10, 2019
@AdrianRaFo AdrianRaFo deleted the mmm/605-docs branch September 25, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants