-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open api generation #659
Open api generation #659
Conversation
…erator. Create the package based on the folder structure and add to the file.
There still some binary issues with [info] [warn] There may be incompatibilities among your library dependencies; run 'evicted' to see detailed eviction warnings.
[info] [error] java.lang.NoSuchMethodError: sbt.package$.fileJsonFormatter()Lsjsonnew/JsonFormat;
[info] [error] at higherkindness.mu.rpc.idlgen.IdlGenPlugin$autoImport$.srcGenSourceDirs$lzycompute(IdlGenPlugin.scala:60)
[info] [error] at higherkindness.mu.rpc.idlgen.IdlGenPlugin$autoImport$.srcGenSourceDirs(IdlGenPlugin.scala:59)
[info] [error] at $1a2dcb12ba29963163ce$.root$lzycompute(build.sbt:19)
[info] [error] at $1a2dcb12ba29963163ce$.root(build.sbt:11)
[info] [error] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[info] [error] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[info] [error] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) |
Thanks @fedefernandez for the fix! Actually, I think we don't need to add the |
... and @BeniVF, thank you for your hard work in this new feature! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, left a minor comment
...es/idlgen/core/src/main/scala/higherkindness/mu/rpc/idlgen/openapi/OpenApiSrcGenerator.scala
Outdated
Show resolved
Hide resolved
...es/idlgen/core/src/main/scala/higherkindness/mu/rpc/idlgen/openapi/OpenApiSrcGenerator.scala
Outdated
Show resolved
Hide resolved
...es/idlgen/core/src/main/scala/higherkindness/mu/rpc/idlgen/openapi/OpenApiSrcGenerator.scala
Outdated
Show resolved
Hide resolved
...es/idlgen/core/src/main/scala/higherkindness/mu/rpc/idlgen/openapi/OpenApiSrcGenerator.scala
Outdated
Show resolved
Hide resolved
@BeniVF thanks for the review. I think this is now ready for a second look. Thanks. |
What this does?
This PR resumes the work by @BeniVF , providing support for code generation from Open API specifications.
Checklist