Avoid adding unnecessary imports to generated source files #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating Scala from protobuf files, only add imports for things that are actually referenced in that file.
Refactor for consistency with the other generators. It now returns a list of the lines in the generated file instead of a singleton list containing the whole file contents.
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
==========================================
+ Coverage 81.55% 81.67% +0.12%
==========================================
Files 73 73
Lines 1160 1168 +8
Branches 15 17 +2
==========================================
+ Hits 946 954 +8
Misses 214 214
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating Scala from protobuf files, only add imports for things that are actually referenced in that file.
Also refactor
ProtoSrcGeneratorfor consistency with the other generators. It now returns a list of the lines in the generated file instead of a singleton list containing the whole file contents.TODO in a later PR: pass skeuomorph some kind of flag to tell it whether to use fs2
Streamor MonixObservablewhen generating service code.What this does?
Fixes #637
Checklist