Micro-optimisation: use IOUtils to copy InputStream to byte array #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we copy the bytes using a buffer for performance. It will also generate less garbage than using `Iterator.continually`.
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
=======================================
Coverage 81.67% 81.67%
=======================================
Files 73 73
Lines 1168 1168
Branches 16 16
=======================================
Hits 954 954
Misses 214 214
Continue to review full report at Codecov.
|
BenFradet
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we copy the bytes using a buffer for performance. It will also generate less garbage than using
Iterator.continually.