Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalameta codegen #746

Merged
merged 4 commits into from
Jan 15, 2020
Merged

Scalameta codegen #746

merged 4 commits into from
Jan 15, 2020

Conversation

cb372
Copy link
Member

@cb372 cb372 commented Jan 15, 2020

What this does?

Bump the skeuomorph dependency and use its new scalameta-based printer for source code generation.

Checklist

  • Reviewed the diff to look for typos, println and format errors.
  • Updated the docs accordingly.

@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #746 into master will decrease coverage by 0.22%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
- Coverage   81.39%   81.17%   -0.23%     
==========================================
  Files          73       73              
  Lines        1161     1158       -3     
  Branches       14       14              
==========================================
- Hits          945      940       -5     
- Misses        216      218       +2
Impacted Files Coverage Δ
...ndness/mu/rpc/idlgen/proto/ProtoSrcGenerator.scala 82.35% <71.42%> (-7.65%) ⬇️
...kindness/mu/rpc/idlgen/avro/AvroSrcGenerator.scala 75% <0%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 553f930...c2fe62b. Read the comment docs.

@cb372 cb372 merged commit 26e135f into master Jan 15, 2020
@cb372
Copy link
Member Author

cb372 commented Jan 15, 2020

The coverage went down but it's pretty much impossible to test the error-handling branch. An error in this case basically means a bug in skeuomorph.

@cb372 cb372 deleted the scalameta-codegen branch January 15, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants