Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename srcgen sbt plugin keys #764

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Rename srcgen sbt plugin keys #764

merged 2 commits into from
Jan 24, 2020

Conversation

naree
Copy link
Contributor

@naree naree commented Jan 24, 2020

What this does?

Rename plugin keys to be prefixed with muSrcGen to follow the plugins best practices guideline.
https://www.scala-sbt.org/1.x/docs/Plugins-Best-Practices.html

Checklist

  • Reviewed the diff to look for typos, println and format errors.
  • Updated the docs accordingly.

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #764 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   71.52%   71.52%           
=======================================
  Files          68       68           
  Lines        1036     1036           
  Branches       13       13           
=======================================
  Hits          741      741           
  Misses        295      295

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 621e79d...b128ef6. Read the comment docs.

@fedefernandez
Copy link
Contributor

@naree are you planing to update the docs in a following PR?

@naree
Copy link
Contributor Author

naree commented Jan 24, 2020

@fedefernandez I noticed that @cb372 was working on documentation including removing reference to the idl generation. I am planning to check with @cb372 after this PR is merged to see if any further changes to documentation is necessary.

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@naree naree merged commit d8f6d55 into master Jan 24, 2020
@naree naree deleted the rename-srcgen-sbt-plugin-keys branch January 24, 2020 17:50
@naree
Copy link
Contributor Author

naree commented Jan 28, 2020

Related documents updated #765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants