Updates to scalatest 3.1.0 #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #769 +/- ##
==========================================
+ Coverage 71.23% 72.37% +1.14%
==========================================
Files 68 68
Lines 1036 1086 +50
Branches 13 15 +2
==========================================
+ Hits 738 786 +48
- Misses 298 300 +2
Continue to review full report at Codecov.
|
fedefernandez
approved these changes
Jan 28, 2020
project/ProjectPlugin.scala
Outdated
| @@ -58,7 +58,8 @@ object ProjectPlugin extends AutoPlugin { | |||
| val scalacheck: String = "1.14.3" | |||
| val scalacheckToolbox: String = "0.3.1" | |||
| val scalamock: String = "4.4.0" | |||
| val scalatest: String = "3.0.8" | |||
| val scalatest: String = "3.1.0" | |||
| val scalatestplusScheck = "3.1.0.0-RC2" | |||
There was a problem hiding this comment.
The dependency is not aligned with scalatest? Should we add the type to make it consistent?
There was a problem hiding this comment.
No, it's not. From 3.1.0 they were separated under its own versioning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does?
This PR updates to Scalatest 3.1.0, adding the new
scalatestplus-scalacheckdependency, as it's needed from now on.Checklist