Remove the @message annotation
#798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a relic from the IDL generation feature which has been removed.
cb372
commented
Feb 21, 2020
| @@ -38,10 +38,8 @@ sealed abstract class MethodNameStyle extends Product with Serializable | |||
| case object Unchanged extends MethodNameStyle | |||
| case object Capitalize extends MethodNameStyle | |||
|
|
|||
| class message extends StaticAnnotation | |||
| class option(name: String, value: Any) extends StaticAnnotation | |||
| class outputPackage(value: String) extends StaticAnnotation | |||
| class outputName(value: String) extends StaticAnnotation | |||
There was a problem hiding this comment.
I think these annotations can also go, but I wanted to keep the PR small. Also we need to update skeuomorph to ensure it doesn't include them in generated code.
tzimisce012
approved these changes
Feb 21, 2020
juanpedromoreno
approved these changes
Feb 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #798 +/- ##
==========================================
- Coverage 72.01% 71.96% -0.06%
==========================================
Files 68 68
Lines 1047 1045 -2
Branches 12 12
==========================================
- Hits 754 752 -2
Misses 293 293
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a relic from the IDL generation feature which has been removed.
What this does?
Changes, features, fixes ...
Checklist